Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Metrics to collect configurable #27

Closed
JanThiel opened this issue Feb 24, 2022 · 7 comments
Closed

Make Metrics to collect configurable #27

JanThiel opened this issue Feb 24, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@JanThiel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Metrics are an amazing tool to get insight into an application. But with the major analytics platforms charging by the number of metrics collected, it is a matter of cost to decide which metrics to actually trace. There are several metrics which create an exponential growth in the number of traced metrics.

Describe the solution you'd like
Within admin.php?page=decalog-settings&tab=metrics allow to enable / disable the single metric. This will allow one to limit the metrics to those really required and thus controlling the created costs by the metrics.

Describe alternatives you've considered
Select the metrics to submit within the configured metrics provider. As it might be different for each provider / connection.

Additional context
We use Datadog. With the Decalog default enabled and metrics submitted on a Multisite Environment we very quickly had several hundred metrics billed there. We then disabled the metrics collection for cost reason.

@JanThiel JanThiel added the enhancement New feature or request label Feb 24, 2022
@Pierre-Lannoy
Copy link
Owner

Hi @JanThiel !

That's definitely a really good suggestion. And a must-have feature I will implement in the next version.
I'm currently trying some ways to do that, because unfortunately having checkboxes for all metrics is neither practical nor feasible:

  • all PerfOps One plugins publish metrics via DecaLog (and by this I mean A LOT of metrics ;))
  • as metrics are dynamically published, it would be impossible to have all the list in UI, so impossible to check/uncheck

@JanThiel
Copy link
Contributor Author

JanThiel commented Mar 3, 2022

Thank you :-)
Groups by source would be a possible way to reduce the amount of required config... But I am sure you will come up with a smart and handy solution as always ;-)

@Pierre-Lannoy
Copy link
Owner

Ahaha. Thanks.
Note for now, the best way I found is to allow regex for including/excluding metrics (on a per-logger basis) 🤣
(and it's not even a joke )

@Pierre-Lannoy
Copy link
Owner

Hello @JanThiel !
This feature is implemented and will be available in 3.5.0. Hope you like regex ;)

@Pierre-Lannoy
Copy link
Owner

3.5.0 is out! Can you tell me if it's ok for you now?

@Pierre-Lannoy
Copy link
Owner

Hello @JanThiel !
Do you have some news on this? Is it usable from your point of view?
Thanks ;)

@JanThiel
Copy link
Contributor Author

@Pierre-Lannoy So sorry for not getting back to you! :-/ Simply slipped my todo list...
Feature looks good and is very usable 🚀❤️

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants