-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datadogformatter] Reduced set of status level used for event submission #53
Comments
Hello @JanThiel ! Hope you are well :) As I'm working on DecaLog 3.8.0 (to be ready for WP 6.3), I would like to answer your question. Why the f**ck did I have mapped levels and Datadog status? 🤣 So, of course, DecaLog will implements all statuses. I have to make some tests again but, so far so good: As all status are now catched, I plan to remove the colored square, the level in plain text and the error code in the message log. What do you think about it? In any case, I wanted to thank you a thousand times over for pointing this out to me. If you hadn't, I'd never have come back to see if it was possible. Thanks ❤️ |
@Pierre-Lannoy As always - it is a pleasure feeding you with input and critical questions :-) Thank you very much for the reasoning and fixing it ;-) |
Thanks for your feedback :) |
Hey @Pierre-Lannoy,
more of a question but something we came along trying to do some housekeeping in datadog.
Within
wp-decalog/includes/formatters/class-datadogformatter.php
Lines 41 to 48 in 33f890c
you limit the used status levels to
info
,warning
anderror
although DD does support all of them actually. We stumbled upon this wondering why allNOTICES
where categorized asinfo
in DD and expected some wrong at our pipeline config.Our particular usecase: We store logs depending on their level. Like info can go away after some days whereas warning and error will be stored for 30 days. Now we wanted to split
info
andnotice
to storenotice
longer and dropinfo
even quicker.This helps us optimize mostly the cost structure as well as little bit reducing log bloat in DD ;-).
Just want to get your resoning behind this. As I belive this is intentional as always :-)
If you agree, I would at least move Decalog / PHP
notice
to DDnotice
. If not even setting all of the to their according DD log levels. But that seems a bit "radical" to me at the moment with no actual need.Have a great day and all the best as usual :-)
The text was updated successfully, but these errors were encountered: