Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with node-sass >= 4.8.0 #10

Closed
sqal opened this issue Mar 12, 2018 · 2 comments
Closed

Doesn't work with node-sass >= 4.8.0 #10

sqal opened this issue Mar 12, 2018 · 2 comments

Comments

@sqal
Copy link

sqal commented Mar 12, 2018

I just upgraded node-sass in my project to version 4.8.1 and sass-rem doesn't work correctly anymore. It continues to convert values from rem to px, but doesn't add rem units, example:

font-size: rem(16px); // -> font-size: 1;

informations about my environment:

software version
sass-rem 2.0.0
node-sass 4.8.1
node 9.6.1
Operating System Windows 10 x64
@pierreburel
Copy link
Owner

Good catch, there was an incompatibility with LibSass 3.5 released last week : I shipped 2.0.1 with a fix, it should works now.
Thanks for your report !

@sqal
Copy link
Author

sqal commented Mar 12, 2018

Yes everything works now 👍 Thank you so much for this super quick fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants