Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midiin and midiout don't work #134

Closed
nofrets opened this issue Sep 4, 2018 · 8 comments
Closed

midiin and midiout don't work #134

nofrets opened this issue Sep 4, 2018 · 8 comments
Labels
Projects

Comments

@nofrets
Copy link

nofrets commented Sep 4, 2018

thanks for a great tool.

tested on:
macos 10.12.6, 2.8 GHz Intel Core i7
waveform 9
vst and vst3
44100 Hz 256 samples

created 2 patches to test via PdStalFx
-test1.pd is simple midiin=midiout
-test2.pd tests notein=noteout, midiin, and sysex message to midiout

loaded the patch into PdStalFx in a waveform track and played notes:
test1.pd:
-midiin does not register bangs. no midiout.
test2.pd:
-notein works
-midiin doesn't work again
-sysex note on message [144, 60, 100( to midout results in an empty note message.

here are the pd files. Tried to share project file but pdStalFx only does absolute file references.

tests_pd.zip

Thanks again for your time and effort!

@pierreguillot
Copy link
Owner

I’ll have a look ASAP

@pierreguillot
Copy link
Owner

I fixed it. Can you test it and tell me if it's good for you too ?
CamomileMacOS.zip v1.0.7-beta1

@pierreguillot pierreguillot added this to To do in v1.0.7 via automation Sep 9, 2018
@pierreguillot pierreguillot moved this from To do to In progress in v1.0.7 Sep 9, 2018
@nofrets
Copy link
Author

nofrets commented Sep 9, 2018

Thanks so much for the quick work.

midiin seems to work now, but it is difficult to tell for sure as midiout still has issues for me.

midiout sends a note-on and note-off, but only note 127 with a velocity of 1 every time.

sysex messages seem to have no effect.

Thanks again!

@pierreguillot
Copy link
Owner

Thanks for your feedback. I'll try to check that this week and fix it this week-end.

@pierreguillot
Copy link
Owner

I think I fixed the midiout, can you test this beta version?
CamomileMacOS.zip v1.0.7-beta2
I never used [sysex] I'll have to do further investigation. If you can give me a hint or if you have any idea idea of what going on it would be much appreciated :)
Cheers

@nofrets
Copy link
Author

nofrets commented Sep 20, 2018

I tested using PdStal.vst and this patch:

test.pd.zip

I attached two instances of the PdStal vst with this patch loaded in waveform. The Camomile console prints messages from [midiin] and [sysexin].

[midiin] and [midiout] seem to work great.

I did some sysex retuning tests and found it to be semi-functional. Some messages work, but it seems that others are being truncated.

-note-on [144, 56, 100 ( and note-off [128, 56, 0( messages work.

-longer messages like realtime MTS [240, 127, 127, 8, 2, 0, 1, 56, 56, 121, 40( get truncated. Here is the output from the camomile console in the second instance of the vst wrapper:

sysexin: 127
sysexin: 127
midiin: 240
midiin: 127
midiin: 127
midiin: 0

I think I read about this happening somewhere in the pd-vanilla forums from back in the day but I couldn't find it.

I hope this helps and thanks again for your time!

@pierreguillot
Copy link
Owner

Thanks for the documentation. After further investigation, I understood that SysEx messages must start with F0 (240) and end with F7 (247). So your list should ends with 247: [240 127 127 8 2 0 1 56 56 121 40 247( (and commas are optional).

Using this syntax, the plugin well receives a SysEx message (I send the message from Pd to my DAW - Reaper - using a virtual MIDI buse).

The problem was to output sysex messages via the plugin using the [midiout] object. Now, when the plugin receives MIDI bytes from the patch, it checks the SysEx start and end bytes and it creates a SysEx message if the bytes match. Perhaps, I should implement a more generic approach but I think it works so I'll keep this like that for the moment.

Can you test with this beta release and tell me if everything's working?
CamomileMacOS - v1.0.7-beta4

Thanks a lot for your help!

@nofrets
Copy link
Author

nofrets commented Sep 22, 2018

Great thanks for pointing out my typo. I copied the code from a different patch and clearly it was me doing the truncating!

I haven't tested extensively but so far the PdStal.vst works great, no complaints.

This is great for those wanting to slap together quick vst plugins and share them with others without the barrier of expensive proprietary software or technical knowledge, bravo.

I'm looking forward to future developments (like externals :)

Thanks again for your hard work!

v1.0.7 automation moved this from In progress to Done Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v1.0.7
  
Done
Development

No branches or pull requests

2 participants