Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think it's still depending on some jQuery #15

Closed
Xdabier opened this issue May 12, 2020 · 5 comments
Closed

I think it's still depending on some jQuery #15

Xdabier opened this issue May 12, 2020 · 5 comments

Comments

@Xdabier
Copy link

Xdabier commented May 12, 2020

It's shows me this error
image

when I hover on the Area graph.
and it doesn't show the tooltip

I'm using it on Angular 9.1.4
and the morris.js06 version is 0.6.5

@pierresh
Copy link
Owner

Thanks a lot for your comment, you are right, I introduced a dependency to jquery because I wanted to apply that pull request.. Sorry for this, I need to find another way to escape labels. I just committed a fix in master branch.

@pierresh
Copy link
Owner

I just published a commit, now labels are escaped without needing jquery. I will publish a new version on npm a bit later.

@Xdabier
Copy link
Author

Xdabier commented May 12, 2020

Thanks a lot @pierresh ! so can I use the new commit now, or should I wait for the npm version ?

@Xdabier
Copy link
Author

Xdabier commented May 12, 2020

I just tested the commit right now, and it works fine thanks!

@Xdabier Xdabier closed this as completed May 12, 2020
@pierresh
Copy link
Owner

You are welcome, for your information, I just published the version 0.6.6 on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants