Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character names in not English aren't recognized #24

Closed
avega opened this issue Apr 9, 2019 · 3 comments
Closed

Character names in not English aren't recognized #24

avega opened this issue Apr 9, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@avega
Copy link

avega commented Apr 9, 2019

If character name written in not english alphabet, for example - in russian, then it's not recognized. As well the following dialogue.

@piersdeseilligny
Copy link
Owner

I'm going to look at implementing this, but it would require completely redesigning the regex expressions that currently serve for syntax highlighting and tokenization to use unicode ranges. I also want to make sure the performance difference would be at worst negligeable.

In the meantime, you can force character names by preceding them with @. For example, instead of АДРИАН, use @АДРИАН

@piersdeseilligny piersdeseilligny added feature A feature that should or is being worked on bug Something isn't working and removed feature A feature that should or is being worked on labels Apr 10, 2019
@piersdeseilligny
Copy link
Owner

Turns out this was way easier to fix than I expected. Fixed in 1.2.2, which is currently live in the marketplace.

@avega
Copy link
Author

avega commented Apr 11, 2019

Thank you! That was fast! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants