To-do-list #2
To-do-list #2
Conversation
piesieomane
commented
Jul 5, 2022
•
piesieomane
commented
- Remove all hardcoded items from the tasks array.
- Create a new JavaScript file for the new functionality.
- Implement a function for adding a new task (add a new element to the array).
- Implement a function for deleting a task (remove an element from the array).
- Deleting a task should update all remaining items' indexes, so they represent the current list order and are unique
- All changes to the To-Do List should be saved in local storage.
There was a problem hiding this comment.
STATUS: REQUIRED CHANGES ♻️♻️
Hi @piesieomane
Good job so far! I know you worked hard to implement this project, I really appreciate the effort you put in! But there are some issues that you still need to work on to go to the next project but you are almost there!
To highlight 🍾
- All linters are passing ✔️
- Good commit history ✔️
- Your design looks good 💯 ✔️
- Good PR description ✔️
- Follow GitHub flow ✔️
Required changes ♻️ ♻️
- Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @tresorsawasawa when you comment so I can receive the notification or use slack with the same name.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/style.css
Outdated
| @@ -88,7 +88,7 @@ button { | |||
| } | |||
|
|
|||
| .icon i { | |||
| color: #cfcfcf; | |||
| /* color: #cfcfcf; */ | |||
There was a problem hiding this comment.
- Kindly make sure you remove the commented code lines to make your code base cleaner.
|
|
||
| addBtn.addEventListener('click', (e) => { | ||
| const input = todoInputEl.value; | ||
| e.preventDefault(); | ||
| todoInputEl.value = ''; | ||
| if (!input) return; | ||
| const obj = { | ||
| description: input, | ||
| completed: false, | ||
| index: task.length, | ||
| }; | ||
| task.push(obj); | ||
| localStorage.setItem('task', JSON.stringify(task)); | ||
| renderTasks(); | ||
| }); | ||
|
|
||
| const removeTask = (index) => { | ||
| const newArr = task.filter((element) => element.index !== index); | ||
| task.length = 0; | ||
| let i = 0; | ||
| newArr.forEach((element) => { | ||
| element.index = i; | ||
| i += 1; | ||
| }); | ||
| task.push(...newArr); | ||
| localStorage.setItem('task', JSON.stringify(task)); | ||
| renderTasks(); | ||
| }; | ||
|
|
||
| oneContainer.addEventListener('click', (e) => { | ||
| if (e.target.classList.contains('fa-solid')) { | ||
| const index = parseInt(e.target.getAttribute('id'), 10); | ||
| removeTask(index); | ||
| } | ||
| }); |
There was a problem hiding this comment.
- Kindly make sure you also implement functionality for editing task descriptions is implemented as required for the project(it should also update data in Local storage once you have edited the task description).
There was a problem hiding this comment.
@tresorsawasawa ,thanks for the review, but this functionality I think is for the next project. This is only add and remove functionality
There was a problem hiding this comment.
Hi Piesie,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
