Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots #108

Merged
merged 1 commit into from Mar 31, 2019
Merged

Add screenshots #108

merged 1 commit into from Mar 31, 2019

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Mar 27, 2019

This PR includes:

  • Screenshots for the VRT.NU addon
  • Move icon and fanart to resources/images/

The screenshots are 720p images reduced in size using:

convert -sampling-factor 4:2:0 -strip -quality 85 screenshot-01.orig.png screenshot-01.png

But still quite large, however they compare in size with screenshots of other plugins.

This fixes #107

@dagwieers dagwieers added the enhancement New feature or request label Mar 27, 2019
@dagwieers
Copy link
Collaborator Author

dagwieers commented Mar 27, 2019

Size difference is considerable, almost 10x larger:

-rw-rw-r--. 2 dag dag  290358 26 mrt 20:08 plugin.video.vrt.nu-1.7.0.zip
-rw-rw-r--. 1 dag dag 2351111 27 mrt 15:26 plugin.video.vrt.nu-1.7.0-15ae565.zip

@dagwieers
Copy link
Collaborator Author

dagwieers commented Mar 27, 2019

Shrinking 50% (so reducing to 360p) using:

convert -sampling-factor 4:2:0 -strip -quality 85 -resize 50% main-menu.png screenshot-01.png
convert -sampling-factor 4:2:0 -strip -quality 85 -resize 50% video-listing.png screenshot-02.png
convert -sampling-factor 4:2:0 -strip -quality 85 -resize 50% live-tv.png screenshot-03.png

gives:

-rw-rw-r--. 2 dag dag 290358 26 mrt 20:08 plugin.video.vrt.nu-1.7.0.zip
-rw-rw-r--. 1 dag dag 850430 27 mrt 15:31 plugin.video.vrt.nu-1.7.0-15ae565.zip

@dagwieers dagwieers force-pushed the screenshots branch 2 times, most recently from ca614a0 to a3dfb9c Compare March 27, 2019 14:38
@mediaminister
Copy link
Collaborator

Why shrinking?
My eyes need 1080p
If there are size limitations for the repository, maybe pngquant can provide better quality with lower file sizes.

@pietje666
Copy link
Collaborator

Its only visible in the information about the addon directory. I really doubt alot of people will care about the quality. (i only checked it from laptop screen though)

@dagwieers
Copy link
Collaborator Author

@mediaminister It's a tradeoff, I did not want the screenshots to take 90% of the size of our codebase. But it is true that 360p is very blurry on 1080p in Kodi itself. Still I wonder how much people actually click on the screenshots in Kodi. But I am all for higher quality with low file sizes so maybe we can do better. (That is why I shared the commands)

  • I made the screenshots in 720p on purpose, hoping that shrinking would lead to better results
  • I used Dutch language as that's what most people will be using anyway

@dagwieers
Copy link
Collaborator Author

I just tested with pngquant and it's a very big improvement. Size are somewhat larger, but still 720p.

-rw-rw-r--. 1 dag dag 290202 28 mrt 04:15 plugin.video.vrt.nu-1.7.1.zip
-rw-rw-r--. 1 dag dag 1067846 29 mrt 01:20 plugin.video.vrt.nu-1.7.1-ce06cce.zip

@dagwieers
Copy link
Collaborator Author

dagwieers commented Mar 29, 2019

After tweaking and testing a lot of options and combinations, I think I am the most satisfied with this tradeoff using:

pngquant --posterize 0 --quality 65 --speed 1 --force live-tv.png

This results in:

-rw-rw-r--. 1 dag dag 290202 28 mrt 04:15 plugin.video.vrt.nu-1.7.1.zip
-rw-rw-r--. 1 dag dag 684180 29 mrt 01:39 plugin.video.vrt.nu-1.7.1-ce06cce.zip

So that is my proposal, see #107 for the images.

@dagwieers dagwieers force-pushed the screenshots branch 2 times, most recently from 643f4dc to a569e31 Compare March 29, 2019 00:43
@dagwieers
Copy link
Collaborator Author

Next up is improving the addon descriptions, the README intro, etc.

@pietje666
Copy link
Collaborator

Im fine with any decision about the screenshots btw

@mediaminister
Copy link
Collaborator

Maybe jpeg is more efficient than png for screenshots with video stills

@dagwieers dagwieers force-pushed the screenshots branch 2 times, most recently from 46163a3 to 1c70822 Compare March 31, 2019 20:02
@dagwieers

This comment has been minimized.

@dagwieers dagwieers force-pushed the screenshots branch 2 times, most recently from ff87427 to cb1a1f0 Compare March 31, 2019 21:40
@dagwieers dagwieers merged commit 4d6a46b into add-ons:master Mar 31, 2019
@dagwieers dagwieers added this to the 1.8.0 milestone May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3 screenshots to the add-on
3 participants