Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TV guide menu entry #142

Merged
merged 3 commits into from Apr 25, 2019
Merged

Add a TV guide menu entry #142

merged 3 commits into from Apr 25, 2019

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Apr 24, 2019

So the approach is this:

  • You select the day (today, yesterday, ...)
    • We can go back 1 month, and forward 1 week
    • Giving a long list of 40 entries is not a good interface though
  • You select the channel
  • You get a TV listing for the whole day, with links to play available episodes from the TV-guide

TODO:

  • Translate some strings, clean up the interface somewhat

@dagwieers dagwieers force-pushed the tvguide branch 3 times, most recently from 54c70c8 to 921afaa Compare April 25, 2019 02:22
@dagwieers dagwieers changed the title WIP: Add a TV guide menu entry Add a TV guide menu entry Apr 25, 2019
@dagwieers dagwieers added the enhancement New feature or request label Apr 25, 2019
@dagwieers dagwieers force-pushed the tvguide branch 7 times, most recently from 5273d98 to f9fdeef Compare April 25, 2019 03:35
@dagwieers
Copy link
Collaborator Author

Another question, I would like to have in Dutch "overmorgen, morgen, vandaag, gisteren en eergisteren", but in English we don't have "overmorgen" or "eergisteren", possibly other languages either. So I was wondering how we would cover this. Leave it empty translated, and cover this in the code that if it is empty in the current language, it isn't used ?

I also noticed that in a Dutch interface, the date-strings are in English nevertheless, so that needs fixing too. And then I still need to look into other hardcoded strings/formatting and how to present it better.

I also would like to indicate in the TV Guide the current time/current playing video, so people can more easily start the current playing episode from the beginning. Any ideas on how to improve the TV Guide are very welcome, as it does not feel completely as it should be.

@mediaminister
Copy link
Collaborator

mediaminister commented Apr 25, 2019

Writing code for this "language" problem, seems a bit silly. If there is no single word for it, just use multiple words. You can use "two days ago" for eergisteren and "in two days" for "overmorgen".

Not sure how to improve the TV guide, maybe we need other GUI methods.
Horizontal centering the scrollbar position on the current time item is just an idea, but I don't know it's possible. It will take time to investigate how to make better use of the Kodi GUI.

@dagwieers
Copy link
Collaborator Author

Seems to work fine for me, the few improvements I have in my head can be added in the future as specific improvements.

@dagwieers dagwieers merged commit 6badd2a into add-ons:master Apr 25, 2019
@dagwieers dagwieers added this to the 1.8.0 milestone May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants