Implement fallback for Categories web-scraping #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagwieers
force-pushed
the
channels
branch
4 times, most recently
from
3822867
to
2f0f7dc
Compare
dagwieers
changed the title
Closed
dagwieers
force-pushed
the
channels
branch
2 times, most recently
from
eb20df4
to
21660c2
Compare
|
@mediaminister @pietje666 Interested to hear opinions about this one. |
dagwieers
force-pushed
the
channels
branch
4 times, most recently
from
36d1430
to
bb0a466
Compare
|
I discovered the unit tests were not actually testing anything (except a function call) as the used examples were invalid. Update: Moved to #163 |
dagwieers
force-pushed
the
channels
branch
8 times, most recently
from
80badd3
to
3dfa14f
Compare
This PR includes: - Provide better Studio names - Fall back to hardcoded list of CATEGORIES if web-scraping fails - A hardcoded list of channels (both tv as radio) - Clean up of codebase to use both CHANNELS and CATEGORIES - Generate list of live streams from CHANNELS - Include unit test to ensure hard-coded CATEGORIES is identical to web-scraped list
|
Very nice improvement. Okay to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
We could now run our tests on an hourly basis to confirm that category-listing scraping works and our internal representation is correct and complete.
This implements #57 (comment)
PS The fallback mechanism does not support thumbnails. We could do that, but I expect the thumbnails to change more often.