Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand/Channel selection for Recent items #242

Closed
dagwieers opened this issue May 16, 2019 · 1 comment · Fixed by #265
Closed

Brand/Channel selection for Recent items #242

dagwieers opened this issue May 16, 2019 · 1 comment · Fixed by #265
Labels
enhancement New feature or request
Milestone

Comments

@dagwieers
Copy link
Collaborator

dagwieers commented May 16, 2019

Currently the "Recent items" menu filters out Ketnet and Ketnet Junior, which is quite arbitrary. Since we now have the "My recent items" menu, we may want to remove that filter altogether, or instead opt to make that filter configurable.

Currently the only way I can see this work now is that we have a separate "Channels" tab in the addon Settings, with a list of Channels and an on/off switch. This would be the filter for selecting which channels would affect the default "Recent items" list.

So for the "grown-ups" profile, this would be configured to exclude Ketnet and Ketnet Junior. And for a "kids" profile, this would be configured to only include Ketnet and Ketnet Junior. Users could also opt-out of Sporza or Radio-related material, so that makes perfect sense IMO.

The only downside is that this list of channels/brands is in fact hard-coded in the settings. Which in itself isn't that big of a problem, the list of channels is hardcoded anyway.

Any thoughts ?

@dagwieers dagwieers added the enhancement New feature or request label May 16, 2019
@dagwieers dagwieers added this to the Future milestone May 16, 2019
@dagwieers
Copy link
Collaborator Author

We can use xbmcgui.Dialog().multiselect() for this. I need to test how we can turn this into config items though. The other option is to have a settings-tab with a switch for each channel, and a section-header making clear this only affects Recent and Offline listings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant