Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: undeclared identifier: 'setup' - When running the first example in readme #16

Open
3210jr opened this issue Feb 19, 2023 · 3 comments

Comments

@3210jr
Copy link

3210jr commented Feb 19, 2023

Hey @pietroppeter!

I'm getting the error:

 Error: undeclared identifier: 'setup'

When running the example on the readme. Are there any additional steps after installing the package, or are the exprts missing?

Thanks for the port by the way :) !

@pietroppeter
Copy link
Owner

Hi, I am assuming you are compiling with the C backend? That needs to be compiled with the JS backend (and then the resulting js loaded in a html file). Probably should clarify that, at the moment I think the best way to try out stuff is to try them with nimib: copy source from some of the gallery examples and run the source - this time using standard c backend - you will get an html page with embedded js.

@3210jr
Copy link
Author

3210jr commented Feb 19, 2023

🤦 Yup! Didn't even try the js backend. Thanks for the quick response!

I'd love to contribute! I haven't seen a contribution.md, so I'll just ask here; do you prefer pull requests into the main branch or a specific feature branch?

@pietroppeter
Copy link
Owner

pietroppeter commented Feb 19, 2023

I'd love to contribute!

❤️ most welcome! Feel free to ask any questions here or elsewhere.

I haven't seen a contribution.md, so I'll just ask here; do you prefer pull requests into the main branch or a specific feature branch?

I am not entirely sure what you mean. From my point of view, the pull request will always be from another branch on your fork to p5nim's main, so it does not change much for me. It might be better on your side to create a feature branch though, so that your fork's main and p5nim's main do not diverge and it is easier to do another PR (now directly from GitHub you sync a fork's main to original repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants