Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with AWS regions and windows #13

Open
timoly opened this issue Nov 8, 2012 · 4 comments
Open

Problems with AWS regions and windows #13

timoly opened this issue Nov 8, 2012 · 4 comments

Comments

@timoly
Copy link

timoly commented Nov 8, 2012

The current version of grunt-s3 uses an old version of knox, package.json explicity defines knox as
"knox": "0.0.9". The latest available version is 0.4.1
The old knox doesn't know how to calculate correct url's for s3 buckets that are not in the default us region, e.g. in Ireland. So all uploads are erroneous with 307 status code.

Also the current system doesn't allow nested folder structure. The destination path is generated using path.join(upload.dest, path.basename(file)); which removes the path from the source file.

Better alternative would be to allow users to define a base path, and then generate the destination using something like
var dest = file.replace(options.basePath, "");

At the moment i am using
upload: [
{
src: 'release/**',
dest: '',
gzip: true,
basePath: 'release/'
}
With my custom version where i want to upload the whole release folder without source folder name.

@pifantastic
Copy link
Owner

Thanks for the report. I'm using knox 0.0.9 because 0.1.0 had a bug that essentially broke all file transfers. However, that's been patched and it's time to upgrade to the latest. I will test with 0.4.1 and if everything looks good, upgrade to that version.

Good point about the destination. I'll see if I can get something working for you.

@mren
Copy link

mren commented Feb 4, 2013

any updates on this?

@pifantastic
Copy link
Owner

Yes @mren, trunk supports a "rel" attribute that will let you upload a wildcard relative to a specific path. I'm in the process of testing it, documenting it, and getting it into npm.

@mren
Copy link

mren commented Feb 6, 2013

awesome :)
On Feb 5, 2013, at 18:50 , Aaron Forsander notifications@github.com wrote:

Yes @mren, trunk supports a "rel" attribute that will let you upload a wildcard relative to a specific path. I'm in the process of testing it, documenting it, and getting it into npm.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants