Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colored icon/slider corresponding to light color #35

Closed
pedolsky opened this issue Feb 5, 2022 · 9 comments
Closed

Allow colored icon/slider corresponding to light color #35

pedolsky opened this issue Feb 5, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@pedolsky
Copy link

pedolsky commented Feb 5, 2022

I'm deeply in love with your awesome project!
Would it be possible to reflect the chosen light color in the icon and/or slider?

@piitaya piitaya added the enhancement New feature or request label Feb 5, 2022
@ImagineerNL
Copy link

+1

This assumes you can select a light color in this card? i was unable to do so. am i missing something or is this not possible?
(i can select the color in another card, but not throught the light card)

@pedolsky
Copy link
Author

pedolsky commented Feb 5, 2022

Here is my code:

type: custom:mushroom-light-card
entity: light.hue_iris
vertical: true
show_brightness_control: true
show_color_temp_control: true
tap_action:
  action: toggle
hold_action:
  action: more-info

Have you defined the hold action?

@ImagineerNL
Copy link

...i'm blind... totally forgot about the hold action.
Was figuring it would work the same as the temperature icon.

@bemble
Copy link
Collaborator

bemble commented Feb 5, 2022

I like the idea, I will take a look to color the icon and/or the slider.

@bemble bemble self-assigned this Feb 7, 2022
@bemble
Copy link
Collaborator

bemble commented Feb 7, 2022

I'm not sure that coloring the slider is a good idea, it can make the whole component less understandable I my opinion.

@pedolsky
Copy link
Author

pedolsky commented Feb 8, 2022

If you think it's going to be too confusing, better drop it. People love your project precisely because of its user-friendliness.

@bemble
Copy link
Collaborator

bemble commented Feb 8, 2022

If you think it's going to be too confusing, better drop it. People love your project precisely because of its user-friendliness.

Thank you! Well, when I look at the Apple expert UX designer solution, I guess I was wrong! I'll give a try today, it will be the last try before closing the first version of this feature 😉

RPReplay_Final1644308872.MP4

@bemble
Copy link
Collaborator

bemble commented Feb 8, 2022

Done in #48

@bemble bemble closed this as completed Feb 8, 2022
@pedolsky
Copy link
Author

pedolsky commented Feb 9, 2022

Love it! Thank you so so so much.

Only show_color_control doesn’t work, yet (maybe Apple related), but I didn’t expect a bonus :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants