Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alarm panel group #75

Closed
bemble opened this issue Feb 9, 2022 · 4 comments · Fixed by #85
Closed

Remove alarm panel group #75

bemble opened this issue Feb 9, 2022 · 4 comments · Fixed by #85
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bemble
Copy link
Collaborator

bemble commented Feb 9, 2022

Alarm group should be handled using alarm template. To handle when panels have different state and display it in the card, we should handle partial states: partially_armed, partially_disarmed etc.

@bemble bemble added the enhancement New feature or request label Feb 9, 2022
@bemble bemble added this to the 1.0.1 milestone Feb 9, 2022
@bemble bemble self-assigned this Feb 9, 2022
@piitaya
Copy link
Owner

piitaya commented Feb 9, 2022

I think we can add a list : "warning_states" to allow custom warning states (because partially states are not official). Or we just use split("_") 😂

@bemble
Copy link
Collaborator Author

bemble commented Feb 9, 2022

Problem value_template can only return one of those states: armed_away, armed_home, armed_night, arming, disarmed, pending, triggered and unavailable (the doc).

Every other state such as partially_armed will set state to unknown. And there is no way to add custom attributes to the entity. So custom state is not the way to do.

@bemble
Copy link
Collaborator Author

bemble commented Feb 9, 2022

Another way to do it, and I think that's the best, is to allow user to add alarm panels in a list in the panels configuration and use this list to check if all panels have the same state. This is way cleaner, it won't use any unofficial state or any other tweak.

What do you think about this solution @piitaya ?

@piitaya
Copy link
Owner

piitaya commented Feb 9, 2022

Do you have any desync issue with alarm templates ? May be you can just add a card or a chip to show that there is a problem ?
I think that not a problem solvable with mushroom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants