You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Look into deprecation/dropping of climate.MapPlots, as discussed in #196:
double check whether climate.MapPlots's functionality is fully covered by climate.CartopyPlots (at least basic features are covered according to @zugnachpankow)
delete climate/map_plots.py
rename CartopyPlots to MapPlot?
update all occurrences and tests of MapPlots
update README.rst accordingly by removing PyNGL and Matplotlib Basemap from 'optional dependencies'
The text was updated successfully, but these errors were encountered:
Looking into this a bit I found that CartopyPlots does not feature a couple of things that MapPlots did. However, I find this legitimate for the sake of simplicity, only that I would then find it consequent to make it even simpler. Here's an idea:
MapPlots features plotting multiple datasets to a single pdf file or to multiple pdf files, or just displaying them in a window.
CartopyPlots simply plots every dataset to a separate png-file. I feel like this basic plotting feature is totally sufficient, but then why even bother storing datasets in self.map_data? (note that self.map_mult_data is unused there) Why not just shortcut add_dataset() and generate_plots() and have something like:
classMapPlot:
def__init__(self, grid, title):
# initialise cartopy plot based on given Grid objectdefplot(self, title, data, file_name, title_on=True, labels_on=True):
# plot given dataset on the Grid, then show and/or save to specified file
This would also resolve the question of intermediately storing datasets in lists or, for large datasets, npy-files, which was another extra feature of MapPlots. Beyond that, it might be nice to add the option to display the plot that is saved (sth like if keyword: plt.show()), and specify the file type (keeping png as default). Could also have separate plot() and savefig() methods, as in matplotlib ..
@ntfrgl, @jdonges, what do you think? @zugnachpankow, would you be up to implement such a thing?? Then we could finally substitute the apparently stale MapPlots class!
Look into deprecation/dropping of
climate.MapPlots
, as discussed in #196:climate.MapPlots
's functionality is fully covered byclimate.CartopyPlots
(at least basic features are covered according to @zugnachpankow)climate/map_plots.py
CartopyPlots
toMapPlot
?MapPlots
README.rst
accordingly by removing PyNGL and Matplotlib Basemap from 'optional dependencies'The text was updated successfully, but these errors were encountered: