You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As generateIIASASubmission() is now the designated way of filtering REMIND
data for publication submissions, there are a couple of issues that need
addressing.
generateIIASASubmission() documentation is missing.
The description only repeats the title, there is no explanation what steps
are taken between .mif files and submission file, the interaction of
different parameters are not clarified.
logFile parameter has unstated dependency on outputDirectory
Setting outputDirectory to something other then output, but not adjusting logFile, leads to
Error in file(file, ifelse(append, "a", "w")) :
cannot open the connection
In addition: Warning message:
In file(file, ifelse(append, "a", "w")) :
cannot open file 'output/missing.log': No such file or directory
Either make sure the directory exists, or better, always write the log to the
stated output directory, which should be what most users expect.
logFile should default to something based on outputFilename
Like sub('\\.[^\\.]+$', '_missing.log', outputFilename), in case users want
to write several submission files but do not want to adjust the name of the
log file everytime.
option to deactivate the log file is missing
Users might not be interested in the file (when converting lots of mifs and
being aware of the state of the reporting). They should be able to set logFile to NULL to deactivate it.
add a helper function for getting a list of available mappings
Currently users have to fake-run generateIIASASubmission() without mapping
parameters to get a list of the available mappings.
model parameter should default to NULL
If users want to change the parameter from what is in the mifs, they should
do so explicitly. Preset defaults are easily overlooked.
cannot combine mapping and mappingFile parameters
Since the documentation is lacking, I was under the impression that the mapping and mappingFile parameters work basically the same, but that the
latter explicitly expects a path to a file, while the former accepts both
mapping names and paths.
But while it is possible to pass multiple mappings to mapping
### Generating mapping based on templates AR6
# Read AR6
### Generating submission file using mapping AR6, /home/pehl/R/x86_64-pc-linux-gnu-library/4.3/piamInterfaces/templates/mapping_template_AR6_NGFS.csv.
# Adapt scenario names: '' will be prepended, '' will be removed.
# Apply mapping /home/pehl/R/x86_64-pc-linux-gnu-library/4.3/piamInterfaces/templates/mapping_template_AR6_NGFS.csv
but the resulting file is identical to the one produced by generateIIASASubmission(mapping = 'AR6', …).
I improved the documentation. I think quite a bit regarding the difference of "mapping templates" and "mapping files" is still confusing, but @fbenke-pik will probably address that by making a larger cleanup. Please use the format used by the csv files in ./inst/template/ for your project.
As
generateIIASASubmission()
is now the designated way of filtering REMINDdata for publication submissions, there are a couple of issues that need
addressing.
generateIIASASubmission()
documentation is missing.The description only repeats the title, there is no explanation what steps
are taken between
.mif
files and submission file, the interaction ofdifferent parameters are not clarified.
mapping
parameters interact (setunion, set difference, …?)
mapping
parameter isnot documented
logFile
parameter has unstated dependency onoutputDirectory
Setting
outputDirectory
to something other thenoutput
, but not adjustinglogFile
, leads tostated output directory, which should be what most users expect.
outputFilename
Like
sub('\\.[^\\.]+$', '_missing.log', outputFilename)
, in case users wantto write several submission files but do not want to adjust the name of the
log file everytime.
Users might not be interested in the file (when converting lots of mifs and
being aware of the state of the reporting). They should be able to set
logFile
toNULL
to deactivate it.FALSE
please.Currently users have to fake-run
generateIIASASubmission()
without mappingparameters to get a list of the available mappings.
model
parameter should default toNULL
If users want to change the parameter from what is in the mifs, they should
do so explicitly. Preset defaults are easily overlooked.
# Adapt scenario names: '' will be prepended, '' will be removed.
# iiasatemplate does not exist, returning full list of variables.
mapping
andmappingFile
parametersSince the documentation is lacking, I was under the impression that the
mapping
andmappingFile
parameters work basically the same, but that thelatter explicitly expects a path to a file, while the former accepts both
mapping names and paths.
But while it is possible to pass multiple mappings to
mapping
mappingFile
mapping
and amappingFile
ignores the mapping inmappingFile
, while reporting using itgenerateIIASASubmission(mapping = 'AR6', …)
.mapping
, you cannot also use amappingFile
at the moment. The script will now warn you.The text was updated successfully, but these errors were encountered: