adds baseUrl to web_modules imports #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
reviewed
Jun 11, 2020
| @@ -315,7 +315,8 @@ export async function command(commandOptions: CommandOptions) { | |||
| return spec; | |||
| } | |||
| if (dependencyImportMap.imports[spec]) { | |||
| let resolvedImport = path.posix.resolve( | |||
| let resolvedImport = path.posix.join( | |||
There was a problem hiding this comment.
This seems fine to me. Not sure why we were using resolve() before, since we seem to just be concatening, not resolving its on-disk location.
drwpow
reviewed
Jun 11, 2020
| // web_modules imports should be rewritten to add baseUrl | ||
| const outputJS = fs.readFileSync(path.resolve(__dirname, 'build', '_dist_', 'index.js'), 'utf8'); | ||
|
|
||
| expect(outputJS).toContain('/static/web_modules/array-flatten.js'); |
drwpow
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #474 (comment) and #476. Fixes #448.
This PR prepends the
config.buildOptions.baseUrlto imports forweb_modulesso that they can be hosted at the same level as the rest of your site, rather than having to live at the domain root.