handle node-fetch, whatwg-fetch Node polyfills #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/cvd76z0sc |
FredKSchott
force-pushed
the
handle-node-fetch
branch
from
c7b5f0a
to
e0d1770
Compare
FredKSchott
force-pushed
the
handle-node-fetch
branch
from
e0d1770
to
519ea0c
Compare
FredKSchott
force-pushed
the
handle-node-fetch
branch
from
519ea0c
to
57e8967
Compare
FredKSchott
force-pushed
the
handle-node-fetch
branch
from
57e8967
to
a2db37f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://www.pika.dev/npm/snowpack/discuss/395
node-fetch is a Node-specific polyfill for the browser-native fetch API. It really should never make its way into your web-based project, but some npm dependencies reference it internally. At worst it will break (see discussion) and at best it's unnecessary bloat for your final build.
On the Pika CDN, we actually replace node-fetch and whatwg-fetch with native calls to the fetch API. This PR brings that same kind of handling to Snowpack.