Fix fast-refresh plugin #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like FredKSchott#659 missed pulling the `filePath` value out of the transform arguments, which leads to all files processed by this plugin failing to build.
Currently errors which occur while building a file are silently swallowed within the dev server, which makes them slightly harder to track down.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/i7ru8pu14 |
drwpow
approved these changes
Aug 1, 2020
|
Thanks! We have trouble testing dev-only plugins and missed this one, will get out the update asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It looks like #659 missed pulling the
filePathvalue out of the transform arguments, which leads to all files processed by this plugin failing to build. This change fixes that, and adds some additional logging to make similar issues more obvious to debug in the future.Testing
The current issue can be reproduced pretty easily in a fresh snowpack react app by just installing
@snowpack/plugin-react-refreshand adding it to thepluginsarray, then runningnpm start. The app that opens will be blank, and the devtools network panel shows a 500 loading/_dist_/App.js. After making this change to the plugin, the app will load & fast refresh appears to work correctly.