Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useClipboard): added a new composable #709

Merged
merged 14 commits into from
Jan 1, 2021

Conversation

Eyoatam
Copy link
Contributor

@Eyoatam Eyoatam commented Dec 26, 2020

No description provided.

Copy link
Owner

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that change, thank you 👍

docs/composable/web/clipboard.md Outdated Show resolved Hide resolved
Co-authored-by: Carlos Rodrigues <david-181@hotmail.com>
@Eyoatam Eyoatam requested a review from pikax December 27, 2020 12:53
@pikax
Copy link
Owner

pikax commented Dec 27, 2020

I'm failing to get the docs example working on my local environment, I will get in it working in the mean time.

Thank you

@Eyoatam
Copy link
Contributor Author

Eyoatam commented Dec 27, 2020

It wasn't working on my local environment either, I Think the problem is the package hasn't been updated 🤔

It works when you use the relative path to the compiled clipboard.js file ../../../dist/packages/vue-composable/src/web/clipboard

@pikax
Copy link
Owner

pikax commented Jan 1, 2021

It wasn't working on my local environment either, I Think the problem is the package hasn't been updated 🤔

The reason was you were missing the export on the index.ts

Made a few changes to the API to be a bit more understandable and also added the automatic get of the the clipboard on focus

@pikax pikax merged commit e2d12c9 into pikax:master Jan 1, 2021
@pikax
Copy link
Owner

pikax commented Jan 1, 2021

Thank you for the PR 👍

@Eyoatam Eyoatam deleted the feat/new-composable branch January 1, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants