Feat/add useCookie composable #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR, this one is a bit tricky because of the dependency to
|
Thank you, I will contribute after learn @vue-composable/axios.🤗 |
|
Hi, pikax I added a new repo for useCookie and I learned a lot. |
# Conflicts: # packages/axios/package.json # yarn.lock
pikax
approved these changes
Feb 10, 2021
It's ok. In china, these day are new year's day, best wish for you. |
pikax
added a commit
that referenced
this pull request
Feb 20, 2021
* feat(composable): add a new composable * chore: update tests to use fake timers * refactor(use-cookie): add new repo for useCookie. * chore: few changes * chore: fix example on readme * chore: remove extra peerDependency * chore: build Co-authored-by: pikax <carlos@hypermob.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, pikax
I added a new composable that is useCookie, it used js-cookie library.
can you review this PR?