Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow_overwriting_input=True erases original file if Ctrl+C is hit during .save() #462

Closed
jbarlow83 opened this issue Mar 18, 2023 · 1 comment
Closed

allow_overwriting_input=True erases original file if Ctrl+C is hit during .save() #462

jbarlow83 opened this issue Mar 18, 2023 · 1 comment

Comments

@jbarlow83
Copy link
Member

When we open the file for write, it's gone, and if we fail to rewrite it or user interrupts the process, it will be deleted.
When in this mode we should write to a temporary file and rename on success.
@jbarlow83
Copy link
Member Author

Fixed in 8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbarlow83