Change internal structure in Query and QueryTree
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of their members are hidden, and some accessor functions are added.
It makes the role of as the node of pattern tree clear.
The argument `level` in `Parser::basic_parse` and `Parser::speculative_parse` has removed because their value is the same as `QueryNode::level`.
|
Thanks for the refactoring and sorry for the late reply. I'll check the performance of this pr version later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also renames
QuerytoQueryNode, to clarify the role of them as a node in pattern tree.Note that the argument
levelinParser::basic_parse()andParser::speculative_parse()has also moved toQueryNode, because they are the same as the level of node in pattern tree.