New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SF Symbols 4 #107
Comments
I updated
from / using the SF Symbols 4 Beta app and regenerated the code. Fortunately, everything went fine, so there's now experimental v4 support: I think there are no changes / new features in SF Symbols 4 that require an adaptation of our generator code; but correct me, if I'm wrong. We just need to update |
Okay, there is one minor issue: In the This can be fixed by making the generator tool ignore localizations if the base variant symbol is not listed in the |
I pushed a new commit with the new symbol restrictions file from Xcode 14 Beta. Thanks @Stevenmagdy for documenting the information where to find it (via #108). Interestingly, the Xbox and PS symbols introduced in SF Symbols v3 are now also restricted despite not representing Apple products:
|
As #106 is now merged, this can now be implemented. I think it's a good first issue, so if someone wants to contribute to this repository, this is a good starting point. If nobody wants to do it, I'll do it before the v4 release. |
I have now fixed the issue mentioned above myself. |
The 4.0.0 release is now available: https://github.com/SFSafeSymbols/SFSafeSymbols/releases/tag/4.0.0 |
@fredpi : You know if there is a way to request to add specific symbols. But it would be nice to have them officers. |
@Angelk90 SFSafeSymbols is only meant for the native symbols and not for symbols included in the assets. For your use case, I would recommend extending extension UIImage {
static let git = UIImage(named: "git")!
}
imageView.image = .git |
@Stevenmagdy : In fact I say how can I apply to add it as a native symbol? |
@Angelk90 Unfortunately you really can't add native symbols. Even the linked repo couldn't:
This from their README and in their Usage section you will find |
Hello ✋ @fredpi, could you please refer me to an explanation on how the files in SymbolsGenerator/Resources are generated, or maybe possibly explain ? Thank you. |
@vakhid-betrakhmadov This is documented in the 'Updating to a new SF Symbols version' section of the CONTRIBUTING.md. I hope this answers your question – let me know, if you need further help :) |
@fredpi , many thanks 🙏, that answers my question |
As can be seen here, there will be a new version of SF Symbols: SF Symbols 4. Currently, the SF Symbols 4 app isn't available to download, but it probably won't last long until we learn all about it.
This issue can be used to collect ideas / track progress on the SF Symbols 4 support.
The text was updated successfully, but these errors were encountered: