Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document CI workarounds before release #112

Open
fredpi opened this issue Sep 16, 2022 · 4 comments
Open

Document CI workarounds before release #112

fredpi opened this issue Sep 16, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@fredpi
Copy link
Member

fredpi commented Sep 16, 2022

In the release documentation, a step should be added that describes the need for a locally run pod spec lint before the start of the release. While the lint is run on a CI, different issues may occur on a local machine – for example: the watchOS simulator issues that @StevenMagdy fixed for Bitrise with this code:

xcrun simctl delete all;
phoneID=$(xcrun simctl create "iPhone 14" com.apple.CoreSimulator.SimDeviceType.iPhone-14);
watchID=$(xcrun simctl create "Apple Watch SE (40mm) (2nd generation)" com.apple.CoreSimulator.SimDeviceType.Apple-Watch-SE-44mm-2nd-generation);
tvID=$(xcrun simctl create "Apple TV" com.apple.CoreSimulator.SimDeviceType.Apple-TV-1080p);
xcrun simctl pair $watchID $phoneID;

This workaround may also be added to the documentation.

If we don't add this step to the release instructions, an issue may occur with a version having been released on Github, but the core contributor that released it being unable to push to CocoaPods.

@fredpi fredpi added the documentation Improvements or additions to documentation label Sep 16, 2022
@StevenSorial
Copy link
Member

StevenSorial commented Nov 6, 2022

@fredpi Before documenting the workarounds, let's try to solve the root cause(s) of the issues we faced during releasing 4.0.

One of the first issues we faced was #1242973033, which was during installing extra simulator runtimes using xcode-install, the bug was confirmed here.

xcode-install got deprecated and now recommends migrating to xcodes, which doesn't have the runtimes functionality yet.
I have opened two PRs (first and second) to add the feature to xcodes. Once the PRs are accepted and a new version of xcodes is released, we will try again and see if it fixes the CI.

@StevenSorial StevenSorial changed the title Document need for local CocoaPods Lint before release Document CI workarounds before release Nov 6, 2022
@fredpi
Copy link
Member Author

fredpi commented Nov 8, 2022

@Stevenmagdy Thanks! I'm on a tight schedule currently and will give it a look in ~2 weeks

@StevenSorial
Copy link
Member

Replaced xcode-install with xcodes and now installing extra simulators work as expected. The extra workflow on Bitrise is now removed.

@fredpi
Copy link
Member Author

fredpi commented Nov 20, 2022

@Stevenmagdy That's really great, thank you for going the extra mile even adding this feature to xcodes! 🚀

Regarding this issue: I would propose to still to leave it open and add the note to the release documentation, even if the root cause of the problems is fixed – but we'll never know when the next unexpected problem occurs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants