Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To extract the range streaming #64

Closed
thom4parisot opened this issue Sep 17, 2014 · 6 comments
Closed

To extract the range streaming #64

thom4parisot opened this issue Sep 17, 2014 · 6 comments
Assignees

Comments

@thom4parisot
Copy link

Hello,

in another standalone HTTP server, there is a lack of Range partial content handling.
I found this implementation pretty neat and easy to extract.

Is it something acceptable for you (to extract the code+tests and submit as a PR the replacement as a module dependency)?

Or do you find that too risky/pointless?

Thanks :-)

@dougwilson
Copy link
Contributor

No need; the implementation here is lacking, including the fact it does not support multiple ranges. There is already work underway splitting this module into a bunch of separate pieces, including one that does the ranges stuff.

I'm on vacation right now, so progress is just slowed down :) These modules will end up under the jshttp (https://jshttp.github.io/) banner, btw.

@dougwilson
Copy link
Contributor

And in case you were wondering: I only just started splitting up send last week, right before I went on vacation :)

@dougwilson
Copy link
Contributor

Actually, I'll keep this issue open, so I remember to update you when it's done.

@dougwilson dougwilson reopened this Sep 17, 2014
@dougwilson dougwilson self-assigned this Sep 17, 2014
@thom4parisot
Copy link
Author

Okay great :-)

PS: and enjoy your holidays though ;-)

@dougwilson
Copy link
Contributor

Just wanted to ping you that I'm basically back and resuming work related to this :)

@thom4parisot
Copy link
Author

@dougwilson brilliant thanks :-) Hope you had some good quality time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants