Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

broadcast.SendSync field creation and deletion to all nodes #1132

Merged

Conversation

travisturner
Copy link
Member

@travisturner travisturner commented Feb 21, 2018

Overview

Fields created using the /frame/[frame]/field/[field] endpoint weren't being propagated to all nodes in the cluster. This PR adds CreateFieldMessage and DeleteFieldMessage to the broadcaster.

Fixes #1128

Pull request checklist

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.

Copy link
Member

@jaffee jaffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and tested - seems to clear up the issue.

@travisturner travisturner merged commit 9c9a938 into FeatureBaseDB:master Feb 21, 2018
@travisturner travisturner deleted the broadcast-createfield branch February 21, 2018 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

field not found: schema propagation issue
2 participants