This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Support keys on import CLI. #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaffee
reviewed
Jul 13, 2018
| if err != nil { | ||
| return errors.Wrap(err, "getting field") | ||
| } | ||
|
|
||
| // Translate row keys. | ||
| if field.keys() { |
There was a problem hiding this comment.
I think we should validate in this case that the user hasn't passed row IDs, and similarly in the next block that the user hasn't passed any column IDs.
There was a problem hiding this comment.
Good point. I added validation in 7a5b7c3.
jaffee
suggested changes
Jul 13, 2018
benbjohnson
force-pushed
the
import-key-cli
branch
from
86a1639
to
7a5b7c3
Compare
jaffee
previously approved these changes
Jul 16, 2018
benbjohnson
force-pushed
the
import-key-cli
branch
from
7a5b7c3
to
ed1af55
Compare
|
@jaffee Sorry, I missed some the XOR logic within |
|
@benbjohnson I forgot I wrote some tests when I was reviewing this - could you include them? benbjohnson@df91f81 |
benbjohnson
force-pushed
the
import-key-cli
branch
from
ed1af55
to
490a8cb
Compare
jaffee
approved these changes
Jul 16, 2018
|
ping @benbjohnson - this ok for merge? |
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds support for specifying string keys with
pilosa import. There was an existing partial implementation but it did not work and required both the index and field to use string keys.Keys are translated server-side so performance will be limited by the translation file speed. Previous tests show the speed to be quite high though.
Usage
Given an index
i, a fieldf, and the followingdata.csvfile:The import can be run using the normal import command:
Fixes #1488
Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.