This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Add fuzzing code and readme.md to explain the fuzzer #2004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaqque
previously requested changes
Jun 13, 2019
roaring/README.md
Outdated
|
||
The fuzzer needs some input to start the fuzzing with. Copy some sample fragments into the workdir/corpus folder. Once you have copied your sample inputs, you are ready to run the fuzzer: | ||
|
||
`go-fuzz` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the -bin
, -workdir
, and -func
flags here to be more explicit? The func
and workdir
flags are for supporting multiple fuzzing functions, which would each require different corpuses.
On pull request #2012, alanbernstein suggested that we clarify that the sample fragments are sample Pilosa fragments and that we provide an example on how to copy the fragments into the workdir/corpus folder. The |
16 tasks
shaqque
reviewed
Jun 17, 2019
jaffee
approved these changes
Jun 19, 2019
codysoyland
changed the title
Added fuzzing code and readme.md to explain the fuzzer
Add fuzzing code and readme.md to explain the fuzzer
Sep 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A fuzzer.go file is being added to fuzz the Bitmap.UnmarshalBinary. A readme.md to explain the fuzzer operations is also being added.
Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.