Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Add fuzzing code and readme.md to explain the fuzzer #2004

Merged
merged 10 commits into from Jun 19, 2019

Conversation

asvetlik
Copy link
Contributor

@asvetlik asvetlik commented Jun 13, 2019

Overview

A fuzzer.go file is being added to fuzz the Bitmap.UnmarshalBinary. A readme.md to explain the fuzzer operations is also being added.

Pull request checklist

  • I have read the contributing guide.
  • I have agreed to the Contributor License Agreement.
  • I have updated the documentation.
  • I have resolved any merge conflicts.
  • I have included tests that cover my changes.
  • All new and existing tests pass.
  • Make sure PR title conforms to convention in CHANGELOG.md.
  • Add appropriate changelog label to PR (if applicable).

Code review checklist

This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

  • Ensure that any changes to external docs have been included in this pull request.
  • If the changes require that minor/major versions need to be updated, tag the PR appropriately.
  • Ensure the new code is properly commented and follows Idiomatic Go.
  • Check that tests have been written and that they cover the new functionality.
  • Run tests and ensure they pass.
  • Build and run the code, performing any applicable integration testing.
  • Make sure PR title conforms to convention in CHANGELOG.md.
  • Make sure PR is tagged with appropriate changelog label.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2019

CLA assistant check
All committers have signed the CLA.

@asvetlik asvetlik requested a review from jaffee June 13, 2019 16:16
@jaffee jaffee requested a review from codysoyland June 13, 2019 16:17

The fuzzer needs some input to start the fuzzing with. Copy some sample fragments into the workdir/corpus folder. Once you have copied your sample inputs, you are ready to run the fuzzer:

`go-fuzz`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the -bin, -workdir, and -func flags here to be more explicit? The func and workdir flags are for supporting multiple fuzzing functions, which would each require different corpuses.

@asvetlik
Copy link
Contributor Author

On pull request #2012, alanbernstein suggested that we clarify that the sample fragments are sample Pilosa fragments and that we provide an example on how to copy the fragments into the workdir/corpus folder. The Provided example on how to copy Pilosa fragments in README.md commit implements these suggestions.

@asvetlik asvetlik mentioned this pull request Jun 17, 2019
16 tasks
roaring/README.md Outdated Show resolved Hide resolved
@asvetlik asvetlik dismissed shaqque’s stale review June 19, 2019 17:24

I made the desired changes

@asvetlik asvetlik merged commit 7aa2211 into FeatureBaseDB:master Jun 19, 2019
@codysoyland codysoyland changed the title Added fuzzing code and readme.md to explain the fuzzer Add fuzzing code and readme.md to explain the fuzzer Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants