This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
CountRange was incorrect if rangekey was prior to inital container #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisturner
suggested changes
Aug 9, 2017
roaring/roaring_test.go
Outdated
| @@ -191,6 +191,27 @@ func TestBitmap_Max(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
| func TestBitmap_BitmapCountRangeBug(t *testing.T) { | |||
There was a problem hiding this comment.
let's name this test something other than Bug; that will become meaningless going forward.
fragment.go
Outdated
| @@ -274,7 +274,8 @@ func (f *Fragment) openCache() error { | |||
| // Read in all rows by ID. | |||
| // This will cause them to be added to the cache. | |||
| for _, id := range pb.IDs { | |||
| n := f.row(id, false, false).Count() | |||
| //n := f.row(id, false, false).Count() | |||
travisturner
approved these changes
Aug 10, 2017
seebs
pushed a commit
to seebs/pilosa
that referenced
this pull request
Nov 19, 2020
fix bug on left/right join mapping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Count and CountRange results where not matching due to incorrect handling of less than edge case
Fixes Unreported bug
Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.