This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
refactored httpclient handling #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaffee
approved these changes
Dec 4, 2017
test/executor.go
Outdated
| @@ -15,7 +15,7 @@ type Executor struct { | |||
| // NewExecutor returns a new instance of Executor. | |||
| // The executor always matches the hostname of the first cluster node. | |||
| func NewExecutor(holder *pilosa.Holder, cluster *pilosa.Cluster) *Executor { | |||
| executor := pilosa.NewExecutor(nil) | |||
| executor := pilosa.NewExecutor(pilosa.GetHTTPClient(nil)) | |||
There was a problem hiding this comment.
would it be better to use a default client defined at the package level here, so that we aren't newing up lots of new clients while running tests?
| @@ -50,7 +50,7 @@ func TestMain_Set_Quick(t *testing.T) { | |||
| defer m.Close() | |||
|
|
|||
| // Create client. | |||
| client, err := pilosa.NewInternalHTTPClient(m.Server.URI.HostPort(), nil) | |||
| client, err := pilosa.NewInternalHTTPClient(m.Server.URI.HostPort(), pilosa.GetHTTPClient(nil)) | |||
There was a problem hiding this comment.
would it be better to use a default client defined at the package level here (and the two other places in this file), so that we aren't newing up lots of new clients while running tests?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Multiple instances of the standard go http client where not necessary. This refactor limits to only once instance
Fixes #983
Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.