Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible wrong parameter reference #30

Closed
mrfind opened this issue Mar 12, 2021 · 3 comments
Closed

Possible wrong parameter reference #30

mrfind opened this issue Mar 12, 2021 · 3 comments

Comments

@mrfind
Copy link
Contributor

mrfind commented Mar 12, 2021

Just from reading and trying to understand the code: Shouldn't line 57 compare the state to {3} rather than {2}? Comparing it to time_format doesn't seem right. This may have happended because parameters in line 82 have a different order.

I'd try to fix it myself but I'm still new to Home Assistant programming and GitHub and I have yet to try my first pull request...

Anyway, thanks a lot for providing this component!
Martin
@pilotak
Copy link
Owner

pilotak commented Mar 12, 2021

Thanks fo finding a bug. You are right.
Anyway try to submit a PR I will review it, you can't do anything wrong.

@mrfind
Copy link
Contributor Author

mrfind commented Mar 12, 2021

Ok, I'll look into it over the weekend. I should really learn this anyway!

@pilotak
Copy link
Owner

pilotak commented Mar 13, 2021

fixed via #31

@pilotak pilotak closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pilotak @mrfind