Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Conditioning #132

Open
amcintyre99 opened this issue Aug 22, 2018 · 4 comments
Open

Order Conditioning #132

amcintyre99 opened this issue Aug 22, 2018 · 4 comments

Comments

@amcintyre99
Copy link

I'm assuming since I don't find any mention of order conditioning in node-ib, except in the java ref code, that I won't be able to set these:
http://interactivebrokers.github.io/tws-api/order_conditions.html

Any advice? and if it's a pull request, I will try my best but I've never done one before...

and thanks @pilwon for a great package!!

@tredondo
Copy link
Contributor

and thanks @pilwon for a great package!!

Good package, but needs a little love. Named parameters would be great for a start :)

@pilwon, are you still maintaining this? Open to a PR?

@pilwon
Copy link
Owner

pilwon commented Jun 22, 2019

@meteorpublish I am only maintaining this package. TypeScript rewrite or even enhancing with typescript definitions is highly desired but I unfortunately am not able to invest much time these days. I'd appreciate PRs are always welcomed.

@tredondo
Copy link
Contributor

tredondo commented Jul 2, 2019

@amcintyre99 I'm not sure (well, I hope), that assumption is incorrect. node-ib does support triggerPrice for example, but searching the code for that will only show Java files - I guess because node-ib simply sends down the wire the entire order object you create, without further processing? (@pilwon, is that correct?)

@pilwon: can you confirm whether,

  1. Conditioned orders are supported but we just don't know how to form the requests?
  2. Adjusted orders are supported? See http://interactivebrokers.github.io/tws-api/adjustable_stops.html. I tried variations of that code, but nothing submitted an adjustable order the way you can manually do in TWS.

I'm willing to submit a PR to make adjusted orders work, and then maybe conditioned orders. Just need a little guidance :)

@pilwon
Copy link
Owner

pilwon commented Jul 12, 2019

@meteorpublish Please refer to my response #143 (comment)

You should be able to pass any type of order to .placeOrder(id, contract, order) and I suggest looking for clues in the reference Java code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants