Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: minor error in Falco.Markup docs #100

Closed
sfinnie opened this issue Dec 29, 2022 · 0 comments
Closed

Docs: minor error in Falco.Markup docs #100

sfinnie opened this issue Dec 29, 2022 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sfinnie
Copy link

sfinnie commented Dec 29, 2022

I think there's an error in the code sample under the heading "Combining views to create complex output". It currently reads:

// Template
let master (title : string) (content : XmlNode list) =
    Elem.html [ Attr.lang "en" ] [
        Elem.head [] [
            Elem.title [] [ Text.raw "Sample App" ]
        ]
        Elem.body [] content
    ]

That hard-codes the page title to "Sample App", whereas if I'm right(?) it should use the title parameter. Corrected code:

// Template
let master (title : string) (content : XmlNode list) =
    Elem.html [ Attr.lang "en" ] [
        Elem.head [] [
            Elem.title [] [ Text.raw title ]
        ]
        Elem.body [] content
    ]

Happy to submit a PR though realise it's a trivial change so might be overkill. Thanks.

@pimbrouwers pimbrouwers added the documentation Improvements or additions to documentation label Jan 2, 2023
@pimbrouwers pimbrouwers self-assigned this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants