Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Default-Language in Admin-Interface" #447

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Feb 29, 2024

See: pimcore/pimcore#16548
Requires: pimcore/pimcore#16709

The setting is not used and confuses the user.

All admin user already have a language. There is no need for a default language.

@Corepex Corepex added this to the 1.5.0 milestone Mar 29, 2024
Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kingjia90
Copy link
Contributor

@blankse Could you please merge 1.x into this branch, all tests should be green by effect of requiring 11.3.0-RC1 ? Thank you in advance!

@blankse
Copy link
Contributor Author

blankse commented Jun 18, 2024

@kingjia90 Done

@kingjia90 kingjia90 self-assigned this Jun 18, 2024
@kingjia90 kingjia90 merged commit fbf9568 into pimcore:1.x Jun 18, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
@blankse blankse deleted the remove_admin_language branch June 18, 2024 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants