Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Set default date time formats on startup based on user locale #554

Merged
merged 21 commits into from
Jun 18, 2024

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Jun 6, 2024

Related pimcore/pimcore#17137

Draft: check with the timezone related changes that are conflicting
Naming could be improved, something else instead of short/medium?

@kingjia90

This comment was marked as resolved.

@kingjia90 kingjia90 changed the title [Improvement]: Add new helper to manage date time based on user locale setting [Improvement]: Set default date time formats on startup based on user locale Jun 13, 2024
@markus-moser

This comment was marked as resolved.

@markus-moser

This comment was marked as resolved.

@markus-moser
Copy link
Contributor

The version preview does not respect the datetimeLocale. Would it be a big challenge to apply it there too?

image

@kingjia90
Copy link
Contributor Author

kingjia90 commented Jun 17, 2024

The version preview does not respect the datetimeLocale. Would it be a big challenge to apply it there too?

image

leaving notes here, thank you for the input, yes, it may be a little tricky but would be doable with some work in the backend with the twig and Carbon, maybe better in a follow up PR

<td>{{ object1.getModificationDate()|date('Y-m-d H:i:s') }}</td>
{% endif %}
<td>{{ object2.getModificationDate()|date('Y-m-d H:i:s') }}</td>

@kingjia90 kingjia90 marked this pull request as ready for review June 17, 2024 11:17
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
16.8% Duplication on New Code

See analysis details on SonarCloud

@kingjia90 kingjia90 merged commit 6ae0a3b into 1.x Jun 18, 2024
9 checks passed
@kingjia90 kingjia90 deleted the datetime-locale-settings branch June 18, 2024 09:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants