Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix PHPstan. #446

Closed
martineiber opened this issue Apr 7, 2023 · 0 comments · Fixed by #447
Closed

[Bug]: Fix PHPstan. #446

martineiber opened this issue Apr 7, 2023 · 0 comments · Fixed by #447
Assignees
Labels
Milestone

Comments

@martineiber
Copy link
Contributor

Expected behavior

PHPStan should pass.

Actual behavior

Fix stan error

Error: Ignored error pattern #^Parameter \#1 \$segments of class CustomerManagementFrameworkBundle\\CustomerList\\Filter\\CustomerSegment constructor expects array\<Pimcore\\Model\\DataObject\\CustomerSegment\>, array\<int, CustomerManagementFrameworkBundle\\Model\\CustomerSegmentInterface\> given\.$# in path /home/runner/work/customer-data-framework/customer-data-framework/src/CustomerList/SearchHelper.php was not matched in reported errors.
Error: Parameter #1 $segments of class CustomerManagementFrameworkBundle\CustomerList\Filter\CustomerSegment constructor expects array<Pimcore\Model\DataObject\CustomerSegment>, array<int<0, max>, CustomerManagementFrameworkBundle\Model\CustomerSegmentInterface> given.
Error: Parameter #1 $segments of class CustomerManagementFrameworkBundle\CustomerList\Filter\CustomerSegment constructor expects array<Pimcore\Model\DataObject\CustomerSegment>, array<int<0, max>, CustomerManagementFrameworkBundle\Model\CustomerSegmentInterface> given.

Steps to reproduce

Run PHPStan.

@martineiber martineiber added the Bug label Apr 7, 2023
@martineiber martineiber added this to the v4.0.0 milestone Apr 7, 2023
@martineiber martineiber self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant