Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Use new navigation approach #27

Closed
mattamon opened this issue Feb 9, 2023 · 0 comments · Fixed by #30
Closed

[Improvement]: Use new navigation approach #27

mattamon opened this issue Feb 9, 2023 · 0 comments · Fixed by #30
Assignees
@Corepex
Labels
Improvement
Milestone
v4.0.0

Comments

@mattamon
Copy link

mattamon commented Feb 9, 2023 •
edited
Loading

Improvement description

Instead of a adding the menu in the pimcoreReady event, use the preMenuBuild event

Make sure it stays compatible with Pimcore 10.6

See https://github.com/pimcore/data-hub/blob/1.x/src/Resources/public/js/datahub.js#L24
@Corepex Corepex modified the milestones: v3.1.0, v3.0.11 Feb 22, 2023
@Corepex Corepex mentioned this issue Feb 23, 2023
Merged
@Corepex Corepex linked a pull request Feb 23, 2023 that will close this issue
[Task] Implemented new navigation approach #30
Merged
@mcop1 mcop1 closed this as completed in #30 Feb 27, 2023
@dvesh3 dvesh3 modified the milestones: v3.0.11, v4.0.0 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Corepex Corepex

Labels
Improvement
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

[Task] Implemented new navigation approach pimcore/object-merger
3 participants
@dvesh3 @Corepex @mattamon