Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick correction for browser #14

Closed
rymohr opened this issue Jun 1, 2013 · 1 comment
Closed

Quick correction for browser #14

rymohr opened this issue Jun 1, 2013 · 1 comment
Assignees
Labels

Comments

@rymohr
Copy link

rymohr commented Jun 1, 2013

Too small for a pull request. To work in the browser this line has to be changed:

# currently
this.name = definition()

# should be
this[name] = definition();

Thanks for the library. Exactly what I was looking for!

@pimterry
Copy link
Owner

pimterry commented Jun 1, 2013

Ah yes, good catch! Thanks.

For the record, useful 1 line pull requests like this are totally fine 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants