Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: VJOURNAL support #1094

Open
vuori opened this issue Oct 23, 2021 · 9 comments
Open

Feature: VJOURNAL support #1094

vuori opened this issue Oct 23, 2021 · 9 comments

Comments

@vuori
Copy link

vuori commented Oct 23, 2021

I've been thinking about adding support for VJOURNAL entries to khal. AFAICT these are almost the same as VEVENT, the main difference being that they are implicitly FREE and TRANSPARENT. So it seems that this would mostly need a few UI tweaks to show/hide journal entries in agenda views and maybe allow editing long DESCRIPTIONs in an external editor.

Is there interest in having this in mainline?

(Since many CalDAV servers don't allow pushing VJOURNALs by default a nice extra would be to have a setting to create "compatible" journal entries which are VEVENTs with an X-flag to indicate that these are actually journal entries. KOrganizer has a pretty nice UI for VJOURNALs so there's some benefit to having real ones though.)

@WhyNotHugo
Copy link
Member

WhyNotHugo commented Oct 23, 2021 via email

@vuori
Copy link
Author

vuori commented Oct 23, 2021 via email

@WhyNotHugo
Copy link
Member

WhyNotHugo commented Oct 23, 2021 via email

@vuori
Copy link
Author

vuori commented Oct 23, 2021 via email

@WhyNotHugo
Copy link
Member

I guess there's no reason to not show then in khal's views. I suppose some kind of icon could identify them (maybe configurable? that can be done later tho).

Do you think the same UI for creation makes complete sense? You'd never want alarm (right?) Are invitees a thing?
I do agree that there's a lot of UI to be reused tho, so keeping it in the same project makes sense.

@vuori
Copy link
Author

vuori commented Oct 24, 2021 via email

@NickHastings
Copy link

Just wanted to chime in and add a little more about the use case. Implementing this would allow synchronization with notes in jtx Board on Android.

@vuori
Copy link
Author

vuori commented Oct 26, 2022

Sorry for not getting back on this. Unfortunately this project is stalled and is unlikely to proceed for now.

Adding VJOURNAL support to the backend was quite easy, and basic viewing support was also mostly unproblematic. The big issue turned out to be the create/edit UI: journals involve long DESCRIPTION fields with embedded newlines, and in typical use, the incremental editing of these fields. The major editing modalities (CLI, prompt-based, TUI) are either not really suited to this use at all (the first two) or would require a largish amount of work to handle long text fields well (TUI).

I think dealing with the edit UI question would require some amount of refactoring and a comprehensive vision of how the various editing modalities should work as whole, and I'm not equipped for either task. If there's interest, I can rebase and submit the backend/model side code.

@piater
Copy link

piater commented Oct 26, 2022

How about calling out to $EDITOR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants