test failure: test_dt_two_tz

[lfam]

While building khal 0.7.0 in GNU Guix, the build process fails during the test suite due to the failure of test_dt_two_tz.

Specifically, this assertion fails:
assert ('VCALENDAR',...set([]))]))])) == ('VCALENDAR', ...set([]))]))]))

I've attached the verbose output of that test, and the dependency graph that is used to build khal, excluding implicit inputs such as tar, GCC, etc.

Please let me know if I can provide more information, run other tests, or anything like that.

khal-verbose-failure-output.txt
graph.txt

[geier]

Thanks, we need to wrap that test with freeze_time.

[lfam]

Okay.

Do you think it's safe to disable the test in our packaging? Is it a race / TOCTTOU bug in the tests?

[geier]

Yeas, this is save to disable. Until recently, after every Standard/Daylight-Saving-Time transition either in America/New_York or Europe/Berlin the tests had to be adapted. This is fixed in head.

I know I promised a new release some time ago, but there are still some bugs I want to squash before making a new release.

[lfam]

Okay, thanks for letting me know.

It's no problem for me to disable this test in our package until a new version of Khal is released.

[geier]

@lfam are those gone for you?

[lfam]

Yes, they are gone in 0.8.1. Thanks!

[geier]

Thanks for reporting and confirming.