Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current list() and get_multi() methods don't work in radicale #5

Closed
untitaker opened this issue Mar 2, 2014 · 9 comments
Closed

Current list() and get_multi() methods don't work in radicale #5

untitaker opened this issue Mar 2, 2014 · 9 comments

Comments

@untitaker
Copy link
Member

Before i added CarddavStorage, i added a few tests to the storage test suite.

After i finished writing CarddavStorage and put all the common methods of CaldavStorage and CarddavStorage in a common superclass, i ran the tests and found them failing. It took me embarrassingly long to realize that they didn't break because of some error while doing the refactoring above, but because i added new tests. In other words, CaldavStorage was broken for radicale all the time.

Since i basically copypasted this from geier/khal, i think that the equivalent of these methods is also broken there. That means, only for radicale, AFAICT it still follows the RFC correctly and it seems to work for me on ownCloud.

@untitaker
Copy link
Member Author

Possibly related: Kozea/Radicale#105 Kozea/Radicale#120

@geier
Copy link
Member

geier commented Mar 4, 2014

I got an email from a user in November (2013) claiming that khal worked nicely with (a then current) version of radicale.

@untitaker
Copy link
Member Author

That's kind of worrying, to say the least, because it means that the testsuite doesn't represent real-life situations at all.

@geier
Copy link
Member

geier commented Mar 4, 2014

I'll set up radicale on a server tonight and will try it to sync with it. I'll report back.

@untitaker
Copy link
Member Author

See also the progress on the linked radicale issue. The behavior might also differ between radicale versions maybe?

@geier
Copy link
Member

geier commented Mar 4, 2014

Radicale v0.8 seems to work fine, for the current HEAD I see the same problem as you do.

@untitaker
Copy link
Member Author

The current fix makes 0.8 go green in travis and HEAD go red.

@untitaker
Copy link
Member Author

Filed Kozea/Radicale#121 to fix the remaining failures.

@untitaker
Copy link
Member Author

See comments on Kozea/Radicale#120

The problem was a nested query. The commit that should fix Radicale for that query was completely breaking Radicale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants