Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance? #1

Open
mlund opened this issue Jul 9, 2019 · 6 comments
Open

performance? #1

mlund opened this issue Jul 9, 2019 · 6 comments
Assignees
Labels
WIP Work in progress

Comments

@mlund
Copy link

mlund commented Jul 9, 2019

The following is a comparison of different bitset implementations: https://cs.up.ac.za/cs/vpieterse/pub/PieterseEtAl_SAICSIT2010.pdf.
It would be interesting to see a similar comparison with this library.

@pinam45
Copy link
Owner

pinam45 commented Jul 11, 2019

Yes, I wanted to do some benchmarking to compare with at least std::vector<bool> and boost::dynamic_bitset, maybe using Catch2 benchmarking functionality as it is already a dependancy for the tests.

I am not home for the next ~10 days, but when I come back I will work on it. Thank you for the article, I think it will be useful to see how they benchmarked the different dynamic bitsets and maybe add some others I didn't know about like Qt:QBitArray.

@pinam45 pinam45 self-assigned this Jul 11, 2019
@pinam45
Copy link
Owner

pinam45 commented Jul 22, 2019

I'm back but now I have a summer job so I have little free time left to work on this... I work on it when I can but it will take some time before it is completed.

@mlund
Copy link
Author

mlund commented Jul 23, 2019

Sounds great!

@pinam45
Copy link
Owner

pinam45 commented Aug 11, 2019

I decided to use google/benchmark because I may need the csv/json format output later, to generate performance comparison graphs (maybe with some cool LaTeX magic).

I created a new repository for the benchmarks (pinam45/dynamic_bitset_benchmarks) because multiple bitsets will be benchmarked not only mine, also It will require the benchmarked bitsets as dependencies and I want to keep this repository quite lightweight in size and simple in CMake.

I already pushed the benchmarks CMake/.clang-format/... setup but currently I still do not have much free time to works on this.

@pinam45 pinam45 added the WIP Work in progress label Aug 11, 2019
@CoderLouie
Copy link

There seems to be no to_ulong() method

@pinam45
Copy link
Owner

pinam45 commented Aug 24, 2019

Yes, it will add an undefined behaviour (assert in debug) for bitsets longer than an unsigned long long but it is an useful function, I will add it when I can, probably next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

No branches or pull requests

3 participants