Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing CharField for IntegerField for NoticeSetting model. #38

Closed
wants to merge 2 commits into from
Closed

Replacing CharField for IntegerField for NoticeSetting model. #38

wants to merge 2 commits into from

Conversation

bsnux
Copy link

@bsnux bsnux commented Sep 1, 2014

Fixes #21

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bbfe4da on bsnux:issue-21 into 6782099 on pinax:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bbfe4da on bsnux:issue-21 into 6782099 on pinax:master.

@paltman
Copy link
Member

paltman commented Sep 18, 2014

@bsnux can you update your branch against master and resolve any conflicts? I'd like to get this merged in.

Merge branch 'master' into issue-21
ee106e2 
Conflicts:
	notification/models.py
@bsnux
Copy link
Author

bsnux commented Oct 3, 2014

@paltman Done! :)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ee106e2 on bsnux:issue-21 into 51444fa on pinax:master.

@johndevor
Copy link

poke

@paltman
Copy link
Member

paltman commented Jun 19, 2015

I like the solution in #36 better.

@paltman paltman closed this Jun 19, 2015
@paltman
Copy link
Member

paltman commented Jun 19, 2015

But thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoticeSetting.medium should be IntegerField instead of CharField
4 participants
@bsnux @coveralls @paltman @johndevor