Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue with SubfieldBase on Django 1.9 #183

Closed
paltman opened this issue Nov 12, 2015 · 2 comments
Closed

Address issue with SubfieldBase on Django 1.9 #183

paltman opened this issue Nov 12, 2015 · 2 comments
Milestone

Comments

@paltman
Copy link
Member

paltman commented Nov 12, 2015

This is stemming from latest version of django-jsonfield and will apply pretty widely to Pinax projects/apps.

@paltman paltman added this to the 2.0 milestone Nov 12, 2015
@JPWKU
Copy link

JPWKU commented Nov 13, 2015

I read up on this so I thought I'd write here for posterity.
I browsed the django repository and found this
https://github.com/django/django/blob/aaacaeb0963c406c4fe6f68c6ae51f4a65878250/django/db/models/fields/subclassing.py#L21 ... In fact the sublassing.py module no longer exists. Here is how it was used in django-jsonfield:
django-jsonfield copied that file over into their repo directly here https://github.com/JPWKU/django-jsonfield/blob/master/jsonfield/subclassing.py and used it here https://github.com/JPWKU/django-jsonfield/blob/master/jsonfield/fields.py#L53

@paltman
Copy link
Member Author

paltman commented Nov 14, 2015

I was testing against Django master which has already flipped over to 1.10. The existing django-jsonfield used by Pinax works with 1.9.

However, in the process, I tested jsonfield against master and it worked just fine. We might should re-evaluate the standard Pinax library we use for JSON fields. They seem to have an interchangeable public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants