tox: checkqa: check isort via flake8-isort #420
Conversation
blueyed
force-pushed
the
checkqa-isort-via-flake8
branch
from
de34494
to
3b332f9
Compare
|
Failure can be seen in https://circleci.com/gh/pinax/pinax-stripe/2217. |
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 34 34
Lines 1651 1651
Branches 134 134
=======================================
Hits 1641 1641
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 34 34
Lines 1829 1829
Branches 166 166
=======================================
Hits 1818 1818
Misses 5 5
Partials 6 6
Continue to review full report at Codecov.
|
|
@paltman |
|
A big reason I had avoided flake8-isort was I preferred to keep all the CI config in one place in tox.ini and use the Not following why it's critical to use this wrapper tool. |
|
It integrates nicely with running |
|
I suggest also moving the flake8 config to setup.cfg. |
blueyed
force-pushed
the
checkqa-isort-via-flake8
branch
from
f1406db
to
950dacb
Compare
|
I would prefer to do the opposite and move things into tox.ini and leave setup.cfg for packaging. |
|
what's the argument for moving things out of tox.ini? |
|
The main argument seems to be that I am constantly running into issues where lint complains about single quotes etc (and I get no feedback for the actual tests (see #418)) because of that. IMHO |
|
I have had zero problems with flake8 reading config from tox.ini for years now.
http://flake8.pycqa.org/en/latest/user/configuration.html
… On Oct 23, 2017, at 3:23 PM, Daniel Hahler ***@***.***> wrote:
The main argument seems to be that flake8 does not look at tox.ini by default.
I am constantly running into issues where lint complains about single quotes etc (and I get no feedback for the actual tests (see #418)) because of that.
I use Neomake to run flake8, but that does not help.
IMHO setup.cfg is a good place for config/cfg, while tox.ini is very much specific to tox.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ok, then it might be just flake8-isort. Feel free to close this if you feel inclinded, but I think having a more config-like central place for configuration is a good trade-off for making flake8-isort work out of the box. |
|
And besides that, config/isort is one of the less important issues of this project currently. It's just because of open (and addressed in PR) issues like #418 that config is important for me to fix - since it is currently very disruptive. |
|
Even here we still see that checks for py{35,36}master are waiting for status to be reported, but I've asked several times already to just remove them from the protected branch. |
|
Fixed the master checking |
|
PRs still have to be up-to-date with master, no? |
|
@paltman |
|
I thought |
|
This change does not seem to be in flake8-isort yet. |
|
@paltman |
|
I'm fine with it now. Can you resolve the conflicts and I'll get it merged. I appreciate your patience with me. |
This moves the isort cfg to setup.cfg.
blueyed
force-pushed
the
checkqa-isort-via-flake8
branch
from
950dacb
to
199e20d
Compare
No description provided.