Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when no definition is found for a specified primary key #790

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Warn when no definition is found for a specified primary key #790

wants to merge 12 commits into from

Conversation

Huluk
Copy link

@Huluk Huluk commented Oct 30, 2023

Hopefully fixes #789

I'd like to add a test for this and make sure everything works, but I don't know how to run the tests^^

If I run them using flutter test out of the floor_generator directory, I get the following error:

Error: The class 'FileSystemEvent' can't be extended, implemented, or
mixed in outside of its library because it's a sealed class.
abstract class _ConstructableFileSystemEvent implements FileSystemEvent {

stephanmantel
stephanmantel previously approved these changes Feb 27, 2024
View reviewed changes
@stephanmantel
Copy link
Contributor

Does running flutter pub run test work?

@Huluk
Copy link
Author

Huluk commented Mar 6, 2024

Does running flutter pub run test work?

No, it returns the error I quoted in the first comment. This is, when I run flutter pub run test or dart run test from the floor_generator directory. If I run it from the project root, I get Error: No pubspec.yaml file found.

My Versions:
macOS Sonoma 14.2.1 (23C71)
Flutter 3.19.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 7482962148 (8 days ago) • 2024-02-27 16:51:22 -0500
Engine • revision 04817c99c9
Tools • Dart 3.3.0 • DevTools 2.31.1

@stephanmantel
Copy link
Contributor

Hi,

It seems this is a remnant of old versions and dependencies. In other branches we have updated them and fixed the tests. It is my plan to get these merged soon and when that is done we can also merge this one.

@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (4146037) to head (f4cf69f).
Report is 1 commits behind head on develop.

❗ Current head f4cf69f differs from pull request most recent head 0bfbefa. Consider uploading reports for the commit 0bfbefa to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #790      +/-   ##
===========================================
+ Coverage    91.51%   91.92%   +0.41%     
===========================================
  Files           11       11              
  Lines          224      223       -1     
===========================================
  Hits           205      205              
+ Misses          19       18       -1
Flag Coverage Δ
floor 91.92% <ø> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hendrikvdkaaden
Copy link
Contributor

I have merged the updated develop branch into this one. The tests are now functioning properly.

@Huluk
Copy link
Author

Huluk commented Mar 16, 2024

Thank you!

@stephanmantel
Copy link
Contributor

Could you add a test for this too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanmantel stephanmantel stephanmantel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No warning when one of multiple primary keys is missing
3 participants
@Huluk @stephanmantel @hendrikvdkaaden