You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
v1.2 incorrectly reports that a new version is available because the info.json hosted at http://pinecil.pine64.org/updater/info.json is outdated, reporting v1.1 as the latest version.
Ideally this line would be updated to convert the version string into a float, then make a greater-than comparison to the current version, instead of an inequality check.
Note that this method only works for major-minor versioning. Semantic versioning would require splitting the string by '.' and comparing each version component.
The text was updated successfully, but these errors were encountered:
v1.2 incorrectly reports that a new version is available because the info.json hosted at http://pinecil.pine64.org/updater/info.json is outdated, reporting v1.1 as the latest version.
Ideally this line would be updated to convert the version string into a float, then make a greater-than comparison to the current version, instead of an inequality check.
https://github.com/pine64/pinecil-firmware-updater/blob/b3762d06609a9384ee9179dd63c786c988382109/mainwindow.cpp#L123
https://doc.qt.io/qt-5/qjsonvalue.html#toDouble
Note that this method only works for major-minor versioning. Semantic versioning would require splitting the string by '.' and comparing each version component.
The text was updated successfully, but these errors were encountered: