Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using sequence.maskAbsentMethods #53

Open
pineapplemachine opened this issue Jul 12, 2017 · 1 comment
Open

Stop using sequence.maskAbsentMethods #53

pineapplemachine opened this issue Jul 12, 2017 · 1 comment
Assignees
@pineapplemachine
Labels
effort: high The issue will probably take a single contributor several days of work to resolve. meta: next release The issue must be resolved before the next version can be released. type: polish The issue involves making existing functionality more usable.

Comments

@pineapplemachine
Copy link
Owner

Instead, the supportsAlways and supportsWith attributes of sequences should be inspected in order to accomplish the same thing (that is, omission of methods that are unsupported due to a source not supporting them)
@pineapplemachine pineapplemachine added type: polish The issue involves making existing functionality more usable. effort: high The issue will probably take a single contributor several days of work to resolve. labels Jul 12, 2017
@pineapplemachine pineapplemachine mentioned this issue Jul 31, 2017
Closed
@pineapplemachine
Copy link
Owner Author

Recording here that a lot of progress has been made so far on including supportRequired, supportsAlways, and supportsWith attributes on sequences so far, though still not on all of them. Once all of them have these attributes, I will write the inspection logic

@pineapplemachine pineapplemachine added the meta: next release The issue must be resolved before the next version can be released. label Oct 6, 2017
@pineapplemachine pineapplemachine self-assigned this Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pineapplemachine pineapplemachine

Labels
effort: high The issue will probably take a single contributor several days of work to resolve. meta: next release The issue must be resolved before the next version can be released. type: polish The issue involves making existing functionality more usable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pineapplemachine